fix: ensure same version is reported by extension and MCP sever#93
fix: ensure same version is reported by extension and MCP sever#93
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the version management process for the extension and its MCP server component. By centralizing the version definition in a single root file and automating its injection during the build, it ensures consistency across all components and simplifies future version updates, preventing discrepancies between reported versions. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to unify the versioning for the extension and the MCP server by using a single VERSION file. While the build script is correctly updated to inject this version into the server binary, the gemini-extension.json manifest is changed to a hardcoded development version, which conflicts with the version in the VERSION file. This defeats the primary goal of the PR. I've provided a critical comment to fix this inconsistency. Additionally, I've suggested a minor improvement to the build script for more robust version handling.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 participant
Currently the version reported by the MCP server does not match with the version from release.
Updated workflows to consolidate version string